Repository navigation
Write the large integers in tools/measure_body.exs with digit separators - #86
Merged
HackTuah merged 1 commit intoOct 20, 2026
Merged
Conversation
olehgerus
marked this pull request as ready for review
October 14, 2026 09:48
65536 and 16384 were the only integers over 9999 in the file without underscores; the same list already writes 262_144 and 1_048_576. The values do not change. Closes ScriptKittyOS#76. Before, `mix credo --strict tools/measure_body.exs`: [R] Numbers larger than 9999 should be written with underscores: 65_536 tools/measure_body.exs:90:34 [R] Numbers larger than 9999 should be written with underscores: 16_384 tools/measure_body.exs:90:27 [R] Numbers larger than 9999 should be written with underscores: 65_536 tools/measure_body.exs:44:27 3 mods/funs, found 3 code readability issues. After: "3 mods/funs, found no issues." `mix format --check-formatted tools/measure_body.exs` passes. Signed-off-by: Oleh Gerus <73129739+olehgerus@users.noreply.github.com>
HackTuah
force-pushed
the
measure-body-digit-separators
branch
from
October 20, 2026 15:47
e18a5b2 to
3a38eb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/measure_body.exswrote65536(line 44) and16384and65536(line 90) without digit separators, andmix credo --strict tools/measure_body.exsreported them: "3 mods/funs, found 3 code readability issues." They now read65_536and16_384, as the same list already writes262_144and1_048_576. The values do not change, so the script measures what it measured before.After: credo finds no issues on the file and
mix format --check-formattedpasses. Tooling-only, no CHANGELOG entry. Local gate (OTP 28.1.1 / Elixir 1.18.4): fifteen of sixteen steps pass. The test step fails on an unmodifiedmainon this machine too, on a different timing-sensitive test each run, and each passes alone. Closes #76.